Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use patch by default #589

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Nov 8, 2024

API Platform 4 now uses PATCH by default, PUT is not enabled anymore and needs to be enabled by-hand on the API. This PR changes the default value for our Hydra data provider.

@vincentchalamon
Copy link
Contributor

Fixes #370

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. That could be nice to make this configurable, but this can be done later in another PR.

@soyuka soyuka force-pushed the fix/patch-default branch 2 times, most recently from 94697f2 to e28a691 Compare November 9, 2024 08:51
@soyuka soyuka force-pushed the fix/patch-default branch from 56e7bd9 to 8f69e8f Compare November 9, 2024 09:57
@soyuka
Copy link
Member Author

soyuka commented Nov 9, 2024

Storybook tests are fine locally, still bugged on the CI I need to inestigate at some point.

@soyuka soyuka merged commit 66dca9c into api-platform:main Nov 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants